From a576156e5bf9de147efe2c76af1ee29f5efd773e Mon Sep 17 00:00:00 2001 From: "Rafael G. Martins" Date: Mon, 9 Sep 2019 20:44:18 +0200 Subject: common: prevent stdarg errors when format is NULL --- tests/common/check_error.c | 7 ++++++- tests/common/check_utils.c | 4 ++++ 2 files changed, 10 insertions(+), 1 deletion(-) (limited to 'tests/common') diff --git a/tests/common/check_error.c b/tests/common/check_error.c index d9806f9..1b6f855 100644 --- a/tests/common/check_error.c +++ b/tests/common/check_error.c @@ -28,7 +28,12 @@ test_error_new(void **state) static void test_error_new_printf(void **state) { - bc_error_t *error = bc_error_new_printf(2, "bola %s", "guda"); + bc_error_t *error = bc_error_new_printf(2, NULL); + assert_non_null(error); + assert_int_equal(error->type, 2); + assert_string_equal(error->msg, ""); + bc_error_free(error); + error = bc_error_new_printf(2, "bola %s", "guda"); assert_non_null(error); assert_int_equal(error->type, 2); assert_string_equal(error->msg, "bola guda"); diff --git a/tests/common/check_utils.c b/tests/common/check_utils.c index cc14f4e..471cd77 100644 --- a/tests/common/check_utils.c +++ b/tests/common/check_utils.c @@ -117,6 +117,7 @@ test_strndup(void **state) static void test_strdup_printf(void **state) { + assert_null(bc_strdup_printf(NULL)); char *str = bc_strdup_printf("bola"); assert_string_equal(str, "bola"); free(str); @@ -554,6 +555,9 @@ static void test_string_append_printf(void **state) { bc_string_t *str = bc_string_new(); + str = bc_string_append_printf(str, NULL); + assert_string_equal(str->str, ""); + assert_non_null(str); str = bc_string_append_printf(str, "guda: %s %d", "bola", 1); assert_non_null(str); assert_string_equal(str->str, "guda: bola 1"); -- cgit v1.2.3-18-g5258