aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn Keeping <john@keeping.me.uk>2017-01-15 12:29:38 +0000
committerJason A. Donenfeld <Jason@zx2c4.com>2017-08-10 15:58:24 +0200
commit6d3c8bc37f6124c2193d66587079975d381aa435 (patch)
treeef6b49f3a8882a95a5e1f3fc64b41459b6dac4e7
parent86a6d358f7a6c2432fde86b9e3c5011a656f20e4 (diff)
downloadcgit-6d3c8bc37f6124c2193d66587079975d381aa435.tar.gz
cgit-6d3c8bc37f6124c2193d66587079975d381aa435.tar.bz2
cgit-6d3c8bc37f6124c2193d66587079975d381aa435.zip
ui-atom: properly escape delimiter in page link
If the delimiter here is '&' then it needs to be escaped for inclusion in an attribute. Use html_attrf() to ensure that this happens (we know that hex won't need escaping, but this makes it clearer what's happening. Signed-off-by: John Keeping <john@keeping.me.uk>
-rw-r--r--ui-atom.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ui-atom.c b/ui-atom.c
index 41838d3..3866823 100644
--- a/ui-atom.c
+++ b/ui-atom.c
@@ -63,7 +63,7 @@ static void add_entry(struct commit *commit, const char *host)
html_attr(pageurl);
if (ctx.cfg.virtual_root)
delim = '?';
- htmlf("%cid=%s", delim, hex);
+ html_attrf("%cid=%s", delim, hex);
html("'/>\n");
free(pageurl);
}