From a1429dbc89f9c0945e32cea9fd3424d2fe56aeab Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Mon, 6 Jun 2011 20:49:13 +0000 Subject: cgit.c: add 'clone-url' setting with support for macro expansion The current 'clone-prefix' setting has some known issues: * All repos get the same 'clone-prefix' value since the setting is not adopted during repo registration (in cgitrc, or during scan-path traversal), but only when the setting is used. * The generated clone-urls for a repo is a combination of 'clone-prefix', a slash and the repo url. This doesn't work well with e.g. ssh-style urls like 'git@example.org:repo.git', since the inserted slash will make the repo relative to the filesystem root. * If 'remove-suffix' is enabled, the generated clone-urls will not work for cloning (except for http-urls to cgit itself) since they miss the '.git' suffix. The new 'clone-url' setting is designed to avoid the mentioned issues: * Each repo adopts the default 'clone-url' when the repo is defined. This allows different groups of repos to adopt different values. * The clone-urls for a repo is generated by expanding environment variables in a string template without inserting arbitrary characters, hence any kind of clone-url can be generated. * Macro expansion also eases the 'remove-suffix' pain since it's now possible to define e.g. 'clone-url=git://foo.org/$CGIT_REPO_URL.git' for a set of repos. A furter improvement would be to define e.g. $CGIT_REPO_SUFFIX to '.git' for all repos which had their url prettified, or to store the original $CGIT_REPO_URL in e.g. $CGIT_REPO_REAL_URL before suffix removal. Reviewed-by: Ferry Huberts Signed-off-by: Lars Hjemli --- tests/setup.sh | 1 + tests/t0102-summary.sh | 6 ++++++ 2 files changed, 7 insertions(+) (limited to 'tests') diff --git a/tests/setup.sh b/tests/setup.sh index b2f1169..1e06107 100755 --- a/tests/setup.sh +++ b/tests/setup.sh @@ -62,6 +62,7 @@ enable-log-linecount=1 summary-log=5 summary-branches=5 summary-tags=5 +clone-url=git://example.org/\$CGIT_REPO_URL.git repo.url=foo repo.path=$PWD/trash/repos/foo/.git diff --git a/tests/t0102-summary.sh b/tests/t0102-summary.sh index f0b0d9a..f299c5a 100755 --- a/tests/t0102-summary.sh +++ b/tests/t0102-summary.sh @@ -9,6 +9,9 @@ run_test 'find commit 1' 'grep -e "commit 1" trash/tmp' run_test 'find commit 5' 'grep -e "commit 5" trash/tmp' run_test 'find branch master' 'grep -e "master" trash/tmp' run_test 'no tags' '! grep -e "tags" trash/tmp' +run_test 'clone-url expanded correctly' ' + grep -e "git://example.org/foo.git" trash/tmp +' run_test 'generate bar summary' 'cgit_url "bar" >trash/tmp' run_test 'no commit 45' '! grep -e "commit 45" trash/tmp' @@ -16,5 +19,8 @@ run_test 'find commit 46' 'grep -e "commit 46" trash/tmp' run_test 'find commit 50' 'grep -e "commit 50" trash/tmp' run_test 'find branch master' 'grep -e "master" trash/tmp' run_test 'no tags' '! grep -e "tags" trash/tmp' +run_test 'clone-url expanded correctly' ' + grep -e "git://example.org/bar.git" trash/tmp +' tests_done -- cgit v1.2.3-18-g5258