From 1ddd8df82489815b7e809cc069b7f02ecdb25802 Mon Sep 17 00:00:00 2001 From: Joursoir Date: Mon, 26 Feb 2024 16:39:00 +0300 Subject: ich8lan: warn if disabling ULP failed The hardware may stop working if driver failed to disable ULP mode. Take the return value of e1000_disable_ulp_lpt_lp() into account, and pass up the error if it fails. Signed-off-by: Kai-Heng Feng Signed-off-by: Joursoir --- src/ich8lan.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/ich8lan.c') diff --git a/src/ich8lan.c b/src/ich8lan.c index 8586b67..1eb24fe 100644 --- a/src/ich8lan.c +++ b/src/ich8lan.c @@ -286,7 +286,11 @@ static s32 e1000_init_phy_workarounds_pchlan(struct e1000_hw *hw) * so forcibly disable it. */ hw->dev_spec.ich8lan.ulp_state = e1000_ulp_state_unknown; - e1000_disable_ulp_lpt_lp(hw, true); + ret_val = e1000_disable_ulp_lpt_lp(hw, true); + if (ret_val) { + e_warn("Failed to disable ULP\n"); + goto out; + } ret_val = hw->phy.ops.acquire(hw); if (ret_val) { -- cgit v1.2.3-18-g5258