aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn Keeping <john@keeping.me.uk>2013-04-07 15:06:23 +0100
committerJason A. Donenfeld <Jason@zx2c4.com>2013-04-07 16:07:58 +0200
commit1c32e008c8fda46f812c38f46ae7515bcf8002ee (patch)
tree5dbda13c3fd12af82f7eaf739e6274680030d821
parentb60e6bff75719a5fb0df970bac3be6b2726cf73a (diff)
downloadcgit-1c32e008c8fda46f812c38f46ae7515bcf8002ee.tar.gz
cgit-1c32e008c8fda46f812c38f46ae7515bcf8002ee.tar.bz2
cgit-1c32e008c8fda46f812c38f46ae7515bcf8002ee.zip
ui-blob: don't segfault when no path is given
It it possible to inspect blobs by specifying only the SHA-1, and CGit provides links to do so, for example if a tag points directly at a blob. In this case the path_items structure is never used, but creating it still causes strlen to be run on a null pointer. Fix this. This error was introduced by commit c1633c6 (Update git to v1.7.6.5 - 2013-03-02). Signed-off-by: John Keeping <john@keeping.me.uk>
-rw-r--r--ui-blob.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ui-blob.c b/ui-blob.c
index c59fbcb..7aec0b1 100644
--- a/ui-blob.c
+++ b/ui-blob.c
@@ -80,7 +80,7 @@ void cgit_print_blob(const char *hex, char *path, const char *head)
struct commit *commit;
struct pathspec_item path_items = {
.match = path,
- .len = strlen(path)
+ .len = path ? strlen(path) : 0
};
struct pathspec paths = {
.nr = 1,