aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn Keeping <john@keeping.me.uk>2022-02-13 15:29:06 +0000
committerJason A. Donenfeld <Jason@zx2c4.com>2022-12-19 16:13:58 +0100
commitc1a1d23111b4918798f2605c33130f2ab71bbe7a (patch)
tree34b754a7984b28ec7058dbd018c3536ffeef1e68
parenta0f6669bdb74e58b0ddb3f4283209cd5e58c0eb9 (diff)
downloadcgit-c1a1d23111b4918798f2605c33130f2ab71bbe7a.tar.gz
cgit-c1a1d23111b4918798f2605c33130f2ab71bbe7a.tar.bz2
cgit-c1a1d23111b4918798f2605c33130f2ab71bbe7a.zip
ui-blame: add a link to the parent commit in blame
When walking through the history, it is useful to quickly see the same file at the previous revision, so add a link to do this. It would be nice to link to the correct line with an additional fragment, but this requires significantly more work so it can be done as an enhancement later. (ent->s_lno is mostly the right thing, but it is the line number in the post-image of the target commit whereas the link is to the parent of that commit, i.e. the pre-image of the target.) Suggested-by: Alejandro Colomar <alx.manpages@gmail.com> Signed-off-by: John Keeping <john@keeping.me.uk> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
-rw-r--r--ui-blame.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/ui-blame.c b/ui-blame.c
index 4adec2b..aedce8d 100644
--- a/ui-blame.c
+++ b/ui-blame.c
@@ -54,6 +54,15 @@ static void emit_blame_entry_hash(struct blame_entry *ent)
html("</span>");
free(detail);
+ if (!parse_commit(suspect->commit) && suspect->commit->parents) {
+ struct commit *parent = suspect->commit->parents->item;
+
+ html(" ");
+ cgit_blame_link("^", "Blame the previous revision", NULL,
+ ctx.qry.head, oid_to_hex(&parent->object.oid),
+ suspect->path);
+ }
+
while (line++ < ent->num_lines)
html("\n");
}