diff options
| author | Joursoir <chat@joursoir.net> | 2024-02-26 16:39:00 +0300 |
|---|---|---|
| committer | Joursoir <chat@joursoir.net> | 2024-02-29 18:00:07 +0300 |
| commit | 1ddd8df82489815b7e809cc069b7f02ecdb25802 (patch) | |
| tree | e41d2dc929140d1cec2db3b73f7dec60bd9d8462 | |
| parent | 4dbd389269168d99445450eb5a423b85acc2b0e4 (diff) | |
| download | e1000e-1ddd8df82489815b7e809cc069b7f02ecdb25802.tar.gz e1000e-1ddd8df82489815b7e809cc069b7f02ecdb25802.tar.bz2 e1000e-1ddd8df82489815b7e809cc069b7f02ecdb25802.zip | |
ich8lan: warn if disabling ULP failed
The hardware may stop working if driver failed to disable ULP mode.
Take the return value of e1000_disable_ulp_lpt_lp() into account, and
pass up the error if it fails.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Joursoir <chat@joursoir.net>
| -rw-r--r-- | src/ich8lan.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/ich8lan.c b/src/ich8lan.c index 8586b67..1eb24fe 100644 --- a/src/ich8lan.c +++ b/src/ich8lan.c @@ -286,7 +286,11 @@ static s32 e1000_init_phy_workarounds_pchlan(struct e1000_hw *hw) * so forcibly disable it. */ hw->dev_spec.ich8lan.ulp_state = e1000_ulp_state_unknown; - e1000_disable_ulp_lpt_lp(hw, true); + ret_val = e1000_disable_ulp_lpt_lp(hw, true); + if (ret_val) { + e_warn("Failed to disable ULP\n"); + goto out; + } ret_val = hw->phy.ops.acquire(hw); if (ret_val) { |